Skip to content

[TAS-6838] 💬 Send system emails as 3ook.com 店員 - #1535

Merged
nwingt merged 2 commits into
likecoin:masterfrom
nwingt:tas-6838
Oct 28, 2026
Merged

nwingt merged 2 commits into
likecoin:masterfrom
nwingt:tas-6838

Conversation

@nwingt

@nwingt nwingt commented Oct 28, 2026

Copy link
Copy Markdown
Member

No description provided.

@nwingt
nwingt requested a balanced review from Copilot October 28, 2026 04:26
@notion-workspace

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No objective defects were found—the RFC 2047 encoded sender, parameter removal, and test and snapshot updates were all verified as internally consistent, with the only observation being a clearly intentional, non-blocking sender change.

No open issues 🎉

What changed in this PR

This PR changes the sender identity of system emails so the "From" display name reads 3ook.com 店員 ("3ook.com clerk"). Because AWS SES only accepts ASCII in the Source field, the non-ASCII display name is emitted as an RFC 2047 encoded-word (=?UTF-8?B?<base64>?=). It also consolidates all outgoing templated emails onto this single SYSTEM_EMAIL sender by dropping the per-call source override — including the two sales-notification emails that previously sent from "3ook.com Sales Team" <sales@3ook.com>, which now send from cs@3ook.com as well.

Changes:

  • Encode SYSTEM_EMAIL's non-ASCII display name as an RFC 2047 encoded-word so SES accepts it.
  • Remove the source parameter from sendSESTemplateEmail and always use SYSTEM_EMAIL as Source, dropping the source: SALES_EMAIL overrides on the auto-deliver and manual sales emails.
  • Update the unit test assertion and all snapshot Source values to the encoded sender.
File Description
src/​constant/​index.ts Builds SYSTEM_EMAIL as an RFC 2047 base64 encoded-word for the 3ook.com 店員 display name, with an explanatory comment.
src/​util/​ses.ts Removes the optional source param/override and hardcodes Source: SYSTEM_EMAIL, routing all emails (including sales notifications) through the system sender.
test/​unit/​ses-emails.test.ts Updates the explicit params.Source assertion to the encoded sender.
test/​unit/​__snapshots__/​ses-emails.test.ts.snap Updates all snapshot Source values to the encoded sender.

Note (non-blocking, not filed as a comment since it is clearly intentional per the explicit line removals and snapshot updates): dropping source: SALES_EMAIL means the two sales-notification emails now send from cs@3ook.com instead of sales@3ook.com. If sales@3ook.com is relied on for recipient-side filtering or deliverability, confirm that consolidation is desired.

Review effort: Balanced

@nwingt
nwingt merged commit 1a9885e into likecoin:master Oct 28, 2026
2 checks passed
@nwingt
nwingt deleted the tas-6838 branch October 28, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants