Repository navigation
Add FontReader for on-demand glyph loading - #422
Merged
Merged
Conversation
Font::load parses every glyph of every requested layer up front. Some users (fontc) want the layer and glyph index up front but want to parse glyphs themselves, per glyph, on their own threads, and want that to work the same for a UFO directory, a ufoz and any other FontSource. FontReader reads metainfo.plist, layercontents.plist and each layer's contents.plist when opened; LayerReader then parses one glyph at a time. Font::load_requested_data and Font::load_from_source are now built on the same index, so there is one loading path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have ufoz support in norad, but it isn't usable from fontc because fontc manually parses layer contents and loads glyphs off of disk, so that we can do things in parallel.
This patch is an attempt to provide an API that lets fontc load glyphs individually and in parallel, in such a way that we can also transparently serve glyphs from ufoz archives.
This introduces a bit of new public API, which I've marked as
#[doc(hidden)], and will not consider public for the purposes of semver, until I've actually landed a patch in fontc and confirmed the API is what we want.