Skip to content

Print nodes without ID in --query-all #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emersion wants to merge 1 commit into from
Closed

Print nodes without ID in --query-all #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions crates/resvg/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ OPTIONS:
Useful for debugging


--query-all Queries all valid SVG ids with bounding boxes
--query-all Queries element bounding boxes with optional IDs
--export-id ID Renders an object only with a specified ID
--export-area-page Use an image size instead of an object size during ID exporting

Expand Down Expand Up @@ -622,7 +622,7 @@ fn query_all(tree: &usvg::Tree) -> Result<(), String> {
let count = query_all_impl(tree.root());

if count == 0 {
return Err("the file has no valid ID's".to_string());
return Err("the file has no valid elements".to_string());
}

Ok(())
Expand All @@ -631,13 +631,6 @@ fn query_all(tree: &usvg::Tree) -> Result<(), String> {
fn query_all_impl(parent: &usvg::Group) -> usize {
let mut count = 0;
for node in parent.children() {
if node.id().is_empty() {
if let usvg::Node::Group(group) = node {
count += query_all_impl(group);
}
continue;
}

count += 1;

fn round_len(v: f32) -> f32 {
Expand Down
Loading