Fix Ctrl+L page selector focus in fullscreen - #728
Closed
oliviasch wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in fullscreen, Ctrl+L never focuses the page selector toolbar entry, so the typed page number is ignored and pressing Enter advances to the next page.
In fullscreen the toolbar reveal expression was gated with
&& !fullscreen, so the revealer never opened and the unmapped page entry could not receive focus. The reveal now opens in fullscreen when the toolbar is raised, and the focus grab is deferred until the revealer has shown the child so it lands after the 175ms slide-in transition.Fixes #668
ps - Am a first time open-source contributor! Apologies if this is not the proper workflow :)