Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### 🐛 Bug fixes

- **Android**: A sheet whose `detents` change while it is being presented now settles at the new detents. The change was lost when it landed inside `present()`, so the sheet kept the old stops while its content followed the new ones and left empty space below it. ([#1022](https://github.com/lodev09/react-native-true-sheet/pull/1022) by [@Kijomimi](https://github.com/Kijomimi))

### 💡 Others

- The Expo example in `example/expo` now runs SDK 58, and the SDK 57 example moves to `example/expo-57` (`yarn expo-57`). The bare example is upgraded to React Native 0.88. ([#1016](https://github.com/lodev09/react-native-true-sheet/pull/1016) by [@lodev09](https://github.com/lodev09))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,11 @@ class TrueSheetViewController(private val reactContext: ThemedReactContext) :

isPresented = true
isSheetVisible = true

// setupSheetDetents above resizes the container, and Fabric mounts the pending props right
// there: a detents change applied then saw isPresented false and skipped the reconfigure,
// leaving the behavior on the old stops while the container followed the new ones
if (configuredDetents != detents) setupSheetDetents(applyState = false)
}

fun resize(detentIndex: Int) {
Expand Down
Loading