Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add the optional phoneVerificationMethod, phoneVerificationTime, and phoneWasVerificationSuccessful properties to Location, which Billing and Shipping extend. They are sent as phone_verification_method, phone_verification_time, and phone_was_verification_successful in both /billing and /shipping. They describe the most recent verification of the phone number. The new PhoneVerificationMethod enum lists the valid methods. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oschwald
changed the title
oschwald
force-pushed
the
greg/billing-phone-verification-inputs
branch
from
October 12, 2026 14:56
140b52c to
d158396
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three optional properties to
BillingandShippingthrough their sharedLocationPropsinterface andLocationclass:phoneVerificationMethod:PhoneVerificationMethod.DeliveredCode,.Network, or.Other, serialized asdelivered_code,network, orother.phoneWasVerificationSuccessful: a boolean indicating whether the most recent verification succeeded. Omit it if no verification was attempted.phoneVerificationTime: aDaterepresenting the most recent verification time, serialized as an RFC 3339 timestamp.The properties serialize as
phone_verification_method,phone_was_verification_successful, andphone_verification_timeunder the correspondingbillingorshippingobject. Explicitfalsevalues are preserved.Updates the README examples and changelog. Tests cover the shared location properties and exact JSON serialization for both address objects. The targeted Location, Billing, Shipping, and Transaction tests pass (47 tests).
Part of STF-1906.
Description updated by Codex (GPT-6) on behalf of Greg.