Skip to content

Add 'all' encompassing optional dependency - #499

Open
A-CGray wants to merge 2 commits into
mainfrom
A-CGray-patch-1
Open

A-CGray wants to merge 2 commits into
mainfrom
A-CGray-patch-1

Conversation

@A-CGray

@A-CGray A-CGray commented Oct 12, 2026

Copy link
Copy Markdown
Member

Purpose

Adds the ability to install all optional dependencies using pip install pyoptsparse[all].

I updated the build_real.sh script used by Azure to use this flag when installing pyoptsparse so that we are testing all of pyoptsparse's optional dependencies, not sure if we should do the same in the GHA workflows?

Expected time until merged

2 weeks

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Test pip install -e .[all] locally with success.

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray
A-CGray requested review from a team, ewu63 and marcomangano as code owners October 12, 2026 18:22
@A-CGray
A-CGray requested review from sabakhshi and sanjan98 October 12, 2026 18:22
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.22%. Comparing base (f8d344c) to head (dc41d0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files           1        1           
  Lines         225      225           
=======================================
  Hits          122      122           
  Misses        103      103           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewu63 ewu63 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we missing with the previous [optview,testing] set? We don't need dev/docs right? Agree that GHA should adopt a similar set but I still think it just needs optview/testing.

@A-CGray

A-CGray commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

What are we missing with the previous [optview,testing] set? We don't need dev/docs right? Agree that GHA should adopt a similar set but I still think it just needs optview/testing.

I think [optview,testing] covers everything explicitly required for CI, I just thought it might be good to use [all] so we're testing all of the different optional dependencies. I can go either way on that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants