Error selecting contact TypeError: Cannot read properties of undefined (reading 'errors')

[kennsippell]

Describe the bug
Crash when selecting contact makes it impossible to select some contacts

To Reproduce
https://nairobi.echis.go.ke/#/contacts/1c86192c-c532-52ff-bc41-ff48fa9ecc33

Expected behavior
Can see it

Logs

main.js:1 Error selecting contact TypeError: Cannot read properties of undefined (reading 'errors')
    at main.js:1:2900286
    at Array.forEach (<anonymous>)
    at main.js:1:2900260
    at U.invoke (polyfills.js:1:24482)
    at xt.run (polyfills.js:1:19057)
    at polyfills.js:1:31184
    at U.invokeTask (polyfills.js:1:25102)
    at xt.runTask (polyfills.js:1:19718)
    at Re (polyfills.js:1:27361)

Screenshots

Environment

• Instance: nairobi
• Browser: *
• Client platform: *
• App: webapp
• Version: 5.3.0

Additional context

  return this.searchService
    .search('reports', { subjectIds }, { include_docs: true, limit: this.LIMIT_SELECT_ALL_REPORTS })
    .then(reports => { 
      reports.forEach(report => {
        report.valid = !report.errors || !report.errors.length;   // <-- report is undefined

[ganeshk2846]

Hi! I'd love to fix this by adding a null check for the report object. Can I take this issue?

[jkuester]

@kennsippell thanks for the report. 👍 Couple followup questions:

1. Is this for an online user or offline user (or both)?
2. Was this observed when archiving was actively running on the instance?
3. Is it reproducible across a non-trivial amount of time? (e.g. several hours later can you select the contact or not?)

This is a puzzling place to hit an error because it seems to be that the search index is returning the id of a report that a later _all_docs call does not find. If this is happening for an online user on an instance where we are actively archiving docs, I could see us maybe hitting a race condition where a report could get archived in-between the search query and the _all_docs call, leading to this error. If that's the case, the contact should eventually load if you retry later. However, if this is happening for offline users, etc, then something more confusing is going on.

---

@ganeshk2846 thanks for the interest here! We are still trying to investigate the root-cause of the issue, so not ready for a PR yet. It may be that we just need to filter the results in the GetDataRecordsService, but even for that I would want to do a bit more research around where that service gets used (and if we assume the number of records returned must match the number of ids given....