Repository navigation
Convert Euclidean n-spaces to 0-based indices (part 1) - #5531
Conversation
benjub
left a comment
There was a problem hiding this comment.
Thanks for this work !
I see that you chose the idiom ( 0 ..^ 2 ) instead of { 0 , 1 }. Both have their pros and cons but I haven't looked into details and I rely on your judgment for that choice.
|
Some additional nodes on design choices, especially regarding @avekens's sections about the plane:
I originally meant to include those notes in the initial comment but forgot them yesterday. It is true that the choice |
avekens
left a comment
There was a problem hiding this comment.
Great job, a lot of work! Only one (minor) remark.
And don't forget to transform my appreciated ~eenglngeehlnm in a subsequent PR ;-)
| ehl2eudisval0.d $e |- D = ( dist ` E ) $. | ||
| ehl2eudisval0.0 $e |- .0. = ( { 1 , 2 } X. { 0 } ) $. | ||
| ehl2eudisval0.0 $e |- .0. = ( ( 0 ..^ 2 ) X. { 0 } ) $. |
There was a problem hiding this comment.
ehl2eudisval0.0 $e |- .0. = <" 0 0 "> $.?
There was a problem hiding this comment.
Seems like a nice way to write it (not blocking for this pull request, I wouldn't think, but something to think about).
There was a problem hiding this comment.
Oh, yes, very good idea!
|
Seems like this is ready to merge once @tirix resolves the merge conflicts. |
As proposed in #5416 , this changes the definition of
EEhil(df-ehl) to use 0-based indices, and converts theorems depending on that definition. The index set is changed from( 1 ... N )to( 0 ..^ N ).This is only part one of two, the next step would be to do the same for
EE(df-ee).One theorem is moved to main from my mathbox,
f1od2.Theorems in @avekens's mathbox related to line-sphere intersections have been updated.
Theorem
eenglngeehlnmunfortunately needed to be temporarily commented out, since it refers both toEEHilandEEG, and the former has been converted, but not yet the latter. That theorem should be available again once the conversion is complete.This is D0 on the DALIA scale: No AI was used.