Skip to content

Last block in a "section" of generated Universal Hex in block format is not padded #22

Description

@microbit-carlos

This was done as part of the original design, where the last block doesn't need to be padded as a the End Of File record would be place immediately after.

In the current configuration the Universal Hex first "section" last block is not padded.

// TODO: This test fails because the last block for a section is not padded
// expect(universalHexBlocks).toEqual(hexCombinedBlocks);

As the default implementation now uses only "sections" without the 512-byte blocks this issue is only present for uses actively using the block format.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions