Skip to content

Update Ort::Custom::GetOrtDType() to fix unreachable code warning. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Edward Chen (edgchen1) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Ort::Custom::GetOrtDType() to fix unreachable code warning. #1122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64853ac
Update Ort::Custom::GetOrtDType() to fix unreachable code warning.
edgchen1 Sep 17, 2026
9b691a9
Merge branch 'main' into edgchen1/fix_unreachable_code_warning
sayanshaw24 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions include/custom_op/tensor_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,19 @@ class OrtEagerTensorStorage : public ITensorStorage {
};

template <typename TT>
ONNXTensorElementDataType GetOrtDType(){
constexpr ONNXTensorElementDataType GetOrtDType(){
if constexpr (std::is_same<TT, bool>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_BOOL;
else if constexpr (std::is_same<TT, float>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT;
else if constexpr (std::is_same<TT, double>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_DOUBLE;
#if ORT_API_VERSION >= 16
else if constexpr (std::is_same<TT, MFloat16>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT16;
else if constexpr (std::is_same<TT, BFloat16>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_BFLOAT16;
#endif // ORT_API_VERSION >= 16
else if constexpr (std::is_same<TT, uint8_t>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_UINT8;
else if constexpr (std::is_same<TT, int8_t>::value)
Expand All @@ -159,10 +165,13 @@ ONNXTensorElementDataType GetOrtDType(){
return ONNX_TENSOR_ELEMENT_DATA_TYPE_UINT64;
else if constexpr (std::is_same<TT, int64_t>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_INT64;
else if constexpr (std::is_same<TT, std::string>::value)
else if constexpr (std::is_same<TT, std::string>::value || std::is_same<TT, std::string_view>::value)
return ONNX_TENSOR_ELEMENT_DATA_TYPE_STRING;
ORTX_CXX_API_THROW("Unexpected type", ORT_RUNTIME_EXCEPTION);
return ONNX_TENSOR_ELEMENT_DATA_TYPE_FLOAT;
else {
// Type-dependent false value. Needed for compilers which don't allow static_assert(false) here (see CWG 2518).
constexpr bool always_false = !std::is_same_v<TT, TT>;
static_assert(always_false, "Invalid type");
}
}

class TensorBase : public Arg {
Expand Down
Loading