Repository navigation
Fix GQA shape inference for shape-derived int32 sequence lengths - #33884
Tianlei Wu (tianleiwu) with Copilot wants to merge 8 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the GroupQueryAttention sequence-length shape-inference change.
No open issues 🎉
What changed in this PR
Fixes GroupQueryAttention shape inference for int32 sequence lengths derived from static shapes, addressing the session-creation failure reported in #33865.
Changes:
- Parses sequence-length values using the supplied TensorProto type, supporting propagated
int64values andint32constants while retaining single-element validation. - Adds regression coverage for scalar and one-element inputs, with and without past caches, and checks inferred output dimensions.
| File | Description |
|---|---|
onnxruntime/test/contrib_ops/group_query_attention_shape_inference_test.cc |
Adds constant and shape-derived sequence-length regression cases. |
onnxruntime/core/graph/contrib_ops/bert_defs.cc |
Selects sequence-length parsing based on the TensorProto data type. |
Review effort: Balanced
Retain shape-derived INT64 data handling for INT32 total_sequence_length inputs and its static-shape regressions; incorporate the current-main CI fixes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Maintenance update at The separately reviewable native/navigation repairs are retained. The old f3 iOS attempt 3 ran zero device cases because cold boot exceeded the original setup deadline, then cleanup/hanging Jest reached the job limit. The genuine current-head React Native workflow 42604665463 completed successfully. Fresh iOS artifact The fresh complete all-20 audit at 2026-11-09T13:20:03Z verified this exact current85f9 head open, non-draft, mergeable, with zero unresolved threads and all current-head checks green. The current device and retained640-execution native proof remain valid. This PR's CI preparation is complete; normal human approval remains external. No tests, tolerances, runtime checks or hardware gates were weakened. |
Target the accessible pressable instead of the wrong child text view selected on iOS. Exercise the actual Detox scenario on both platforms and retain the aggregate success assertion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Run the native completion hook before dispatch can release the final worker reference. Preserve exactly-once completion when dispatch throws, and assert completion at promise settlement in the EPContext bridge regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The iOS Button accessibility label is duplicated on native wrappers. Keep its accessibility label but identify the pressable with a unique testID. Reproduce the duplicate-label failure, verify the actual rendered native identifier and navigation, and preserve the complete 14/14 device assertion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iOS device runs have stalled during cold simulator setup before app installation. Reset only the simulator selected by the Detox configuration, then wait for boot and app services without restarting the global CoreSimulator service. Keep app reinstallation, device assertions, and the existing Detox setup deadline unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Description
total_sequence_lengthusing the supplied TensorProto’s type, accepting propagatedint64values andint32constants while preserving single-element validation.Motivation and Context
Shape → Cast(INT32) → Squeezeproduces a validint32sequence length, but shape propagation exposes its value as anint64TensorProto. GQA’s unconditionalint32parsing rejects it during session creation withParseData type mismatch, even when graph optimizations are disabled.GroupQueryAttentionfails to load whentotal_sequence_lengthis computed from static shapes (ParseData type mismatch) #33865