Repository navigation
Fix CPU MoE input corruption from in-place buffer reuse - #33885
Open
Tianlei Wu (tianleiwu) with Copilot wants to merge 4 commits into
Open
Tianlei Wu (tianleiwu) with Copilot wants to merge 4 commits into
Tianlei Wu (tianleiwu) with Copilot wants to merge 4 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MoE output results on CPU with graph inputs
Fix CPU MoE input corruption from in-place buffer reuse
Nov 4, 2026
Tianlei Wu (tianleiwu)
marked this pull request as ready for review
November 6, 2026 17:37
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the CPU MoE buffer-aliasing fix.
No open issues 🎉
What changed in this PR
Fixes CPU MoE input corruption when its output reuses token storage, addressing #33866 without tying buffer preservation to routing-weight normalization.
Changes:
- Copies tokens before clearing the output when input and output buffers alias.
- Adds float32 and float16 regression tests covering graph inputs,
AddandReshape(Add)producers, intermediate and exposed MoE outputs, both normalization modes, and repeated runs.
| File | Description |
|---|---|
| onnxruntime/test/contrib_ops/moe_test.cc | Adds regression coverage for CPU MoE buffer reuse across graph configurations. |
| onnxruntime/contrib_ops/cpu/moe/moe_cpu.cc | Preserves tokens whenever input and output buffers alias. |
Review effort: Balanced
Bring the SentencePiece 0.2.2 pin compatible with CI's protobuf 6.x runtime and refresh current-main validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AddandReshape(Add)producers, intermediate/exposed MoE outputs, and both normalization modes.Motivation and Context
CPU
MoEcan return incorrect results inAdd → MoE → Reluwhen routing normalization is disabled. Its in-place allocation contract permits output to reuse token storage, but clearing that output destroys tokens before expert computation reads them.MoEgives wrong results when its input is computed in the graph and its output feeds another node #33866