Skip to content

flowey: fix github cli auth - #5066

Merged
Steven Malis (smalis-msft) merged 1 commit into
microsoft:mainfrom
tjones60:gh_token
Nov 13, 2026
Merged

Steven Malis (smalis-msft) merged 1 commit into
microsoft:mainfrom
tjones60:gh_token

Conversation

@tjones60

Copy link
Copy Markdown
Contributor

According to this documentation, we should be using GH_TOKEN not GITHUB_TOKEN. This might explain some performance issues and random failures.

@tjones60
Trevor Jones (tjones60) requested a review from a team as a code owner November 12, 2026 22:48
Copilot AI balanced review requested due to automatic review settings November 12, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the update to use GH_TOKEN in the generated GitHub CLI wrappers.

No open issues 🎉

What changed in this PR

Updates Flowey’s GitHub CLI authentication wrapper to use the documented GH_TOKEN environment variable.

Changes:

  • Replaces GITHUB_TOKEN with GH_TOKEN in generated Windows and Unix wrappers, leaving credential selection and authentication checks unchanged.
File Description
flowey/​flowey_lib_common/​src/​use_gh_cli.rs Sets GH_TOKEN when passing configured credentials to the GitHub CLI.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

@smalis-msft
Steven Malis (smalis-msft) merged commit c1a1da8 into microsoft:main Nov 13, 2026
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants