Repository navigation
flowey: fix github cli auth - #5066
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the update to use GH_TOKEN in the generated GitHub CLI wrappers.
No open issues 🎉
What changed in this PR
Updates Flowey’s GitHub CLI authentication wrapper to use the documented GH_TOKEN environment variable.
Changes:
- Replaces
GITHUB_TOKENwithGH_TOKENin generated Windows and Unix wrappers, leaving credential selection and authentication checks unchanged.
| File | Description |
|---|---|
flowey/flowey_lib_common/src/use_gh_cli.rs |
Sets GH_TOKEN when passing configured credentials to the GitHub CLI. |
Review effort: Balanced
Daman Mulye (damanm24)
approved these changes
Nov 13, 2026
Chris Oo (chris-oo)
approved these changes
Nov 13, 2026
Steven Malis (smalis-msft)
approved these changes
Nov 13, 2026
Steven Malis (smalis-msft)
merged commit Nov 13, 2026
c1a1da8
into
microsoft:main
77 of 78 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this documentation, we should be using
GH_TOKENnotGITHUB_TOKEN. This might explain some performance issues and random failures.