Skip to content

Update DacFx to 170.6.56-preview - #2847

Merged
Benjin Dubishar (Benjin) merged 1 commit into
mainfrom
benjin-sts-dacfx-dependency-update
Nov 13, 2026
Merged

Benjin Dubishar (Benjin) merged 1 commit into
mainfrom
benjin-sts-dacfx-dependency-update

Conversation

@Benjin

Copy link
Copy Markdown
Contributor

Description

Update the shared Microsoft.SqlServer.DacFx dependency from 170.6.40-preview to 170.6.56-preview.

The new DacFx package requires Microsoft.Data.SqlClient >= 6.1.8 and Microsoft.SqlServer.TransactSql.ScriptDom >= 180.154.0, so update those direct pins as well to avoid package downgrades. Keep both ManagedBatchParser SqlClient dependency declarations aligned. Leave Microsoft.SqlServer.DacFx.Projects unchanged; its minimum DacFx requirement remains satisfied.

Validation:

  • git diff --check — passed.
  • dotnet restore test/Microsoft.SqlTools.ServiceLayer.UnitTests/Microsoft.SqlTools.ServiceLayer.UnitTests.csproj --source https://www.nuget.org/api/v2/ --source /Users/benjin/Source/copilot-worktrees/sqltoolsservice/benjin-verbose-garbanzo/bin/nuget --disable-parallel --verbosity quiet — passed. Explicit sources were needed because nuget.org is disabled in this machine's effective NuGet configuration.
  • dotnet test test/Microsoft.SqlTools.ServiceLayer.UnitTests/Microsoft.SqlTools.ServiceLayer.UnitTests.csproj --no-restore --filter 'FullyQualifiedName~DacFx|FullyQualifiedName~SqlProjects' --verbosity quiet — passed, 55 tests; also built the consuming projects.
  • Full test suite and SQL-server-dependent integration tests were not run.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (dotnet test)
  • Code follows contributing guidelines
  • Logging/telemetry updated if relevant
  • No protocol or behavioral regressions

Dependency-only update: no new test logic or logging/telemetry changes. The linked CONTRIBUTING.md is absent from this checkout. Targeted existing tests passed as documented above; the full suite was not run.

Reviewers: Please read our reviewer guidelines

@github-actions

Copy link
Copy Markdown

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the DacFx and related dependency version updates.

No open issues 🎉

What changed in this PR

Updates the shared DacFx dependency to 170.6.56-preview and aligns its required dependencies to avoid package downgrades across SQL Tools Service.

Changes:

  • Raises SqlClient to 6.1.8 and ScriptDom to 180.154.0, leaving DacFx.Projects unchanged.
  • Synchronizes both ManagedBatchParser SqlClient declarations with the shared version.
File Description
packages/​Microsoft.SqlTools.ManagedBatchParser/​Microsoft.SqlTools.ManagedBatchParser.nuspec Updates SqlClient for both target frameworks.
Packages.props Updates shared dependency versions and removes the version-specific wording from the SqlClient dependency comment.

Review effort: Balanced

@Benjin
Benjin Dubishar (Benjin) merged commit 13be8a3 into main Nov 13, 2026
8 of 9 checks passed
@Benjin
Benjin Dubishar (Benjin) deleted the benjin-sts-dacfx-dependency-update branch November 13, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants