Repository navigation
Update DacFx to 170.6.56-preview - #2847
Merged
Benjin Dubishar (Benjin) merged 1 commit intoNov 13, 2026
Merged
Conversation
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the DacFx and related dependency version updates.
No open issues 🎉
What changed in this PR
Updates the shared DacFx dependency to 170.6.56-preview and aligns its required dependencies to avoid package downgrades across SQL Tools Service.
Changes:
- Raises SqlClient to
6.1.8and ScriptDom to180.154.0, leaving DacFx.Projects unchanged. - Synchronizes both ManagedBatchParser SqlClient declarations with the shared version.
| File | Description |
|---|---|
packages/Microsoft.SqlTools.ManagedBatchParser/Microsoft.SqlTools.ManagedBatchParser.nuspec |
Updates SqlClient for both target frameworks. |
Packages.props |
Updates shared dependency versions and removes the version-specific wording from the SqlClient dependency comment. |
Review effort: Balanced
Lewis Sanchez (lewis-sanchez)
approved these changes
Nov 13, 2026
Benjin Dubishar (Benjin)
deleted the
benjin-sts-dacfx-dependency-update
branch
November 13, 2026 20:37
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the shared
Microsoft.SqlServer.DacFxdependency from170.6.40-previewto170.6.56-preview.The new DacFx package requires
Microsoft.Data.SqlClient>=6.1.8andMicrosoft.SqlServer.TransactSql.ScriptDom>=180.154.0, so update those direct pins as well to avoid package downgrades. Keep both ManagedBatchParser SqlClient dependency declarations aligned. LeaveMicrosoft.SqlServer.DacFx.Projectsunchanged; its minimum DacFx requirement remains satisfied.Validation:
git diff --check— passed.dotnet restore test/Microsoft.SqlTools.ServiceLayer.UnitTests/Microsoft.SqlTools.ServiceLayer.UnitTests.csproj --source https://www.nuget.org/api/v2/ --source /Users/benjin/Source/copilot-worktrees/sqltoolsservice/benjin-verbose-garbanzo/bin/nuget --disable-parallel --verbosity quiet— passed. Explicit sources were needed because nuget.org is disabled in this machine's effective NuGet configuration.dotnet test test/Microsoft.SqlTools.ServiceLayer.UnitTests/Microsoft.SqlTools.ServiceLayer.UnitTests.csproj --no-restore --filter 'FullyQualifiedName~DacFx|FullyQualifiedName~SqlProjects' --verbosity quiet— passed, 55 tests; also built the consuming projects.Code Changes Checklist
dotnet test)Dependency-only update: no new test logic or logging/telemetry changes. The linked
CONTRIBUTING.mdis absent from this checkout. Targeted existing tests passed as documented above; the full suite was not run.Reviewers: Please read our reviewer guidelines