Repository navigation
[xad] Update to 2.2.0 - #55021
Open
Auto Differentiation Dev Team (auto-differentiation-dev) wants to merge 1 commit into
Open
[xad] Update to 2.2.0#55021Auto Differentiation Dev Team (auto-differentiation-dev) wants to merge 1 commit into
Auto Differentiation Dev Team (auto-differentiation-dev) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Unavailable upstream 2.2.0 sources and CI results prevented independent verification of the removed MSVC/libc++ fixes and Debug/Release tape-layout behavior.
No open issues 🎉
What changed in this PR
Updates the vcpkg xad port to 2.2.0, removes workarounds now included upstream, and keeps Debug and Release tape layouts consistent.
Changes:
- Updates the source checksum, port version, baseline, and version history.
- Removes obsolete compiler patches and version-file rewrites; refreshes the PDB-install patch.
- Disables
XAD_TAPE_CHECKSin both configurations to match the installed headers.
No additional builds or consumer tests were run.
| File | Description |
|---|---|
versions/x-/xad.json |
Adds the 2.2.0 version entry. |
versions/baseline.json |
Advances the default version to 2.2.0. |
ports/xad/vcpkg.json |
Updates the declared version. |
ports/xad/portfile.cmake |
Updates the checksum, removes workarounds, and disables tape checks. |
ports/xad/fix-msvc-stl-145.patch |
Removes the compiler fix included upstream. |
ports/xad/fix-libcxx-21.patch |
Removes the libc++ fix included upstream. |
ports/xad/fix-install-pdb.patch |
Refreshes patch context for 2.2.0. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates xad to 2.2.0 (release: https://github.com/auto-differentiation/xad/releases/tag/v2.2.0).
fix-msvc-stl-145.patchandfix-libcxx-21.patchare removed: both fixes are in 2.2.0.VERSIONfile andVersion.hpp.inare correct in 2.2.0, so the portfile no longer rewrites them.fix-install-pdb.patchis refreshed for 2.2.0 (context offset only).XAD_TAPE_CHECKSis new in 2.2.0 and defaults to ON in Debug builds. It adds a member to the tape class, and only the release headers are installed, so the port sets it OFF for both configurations.Tested on x64-linux (GCC 15):
vcpkg install xad, plus a small consumer usingfind_package(XAD CONFIG REQUIRED)andXAD::xad, built and run in Release and Debug../vcpkg x-add-version --alland committing the result.