[cherry-pick] Avoid Agent Host session listing starvation - #333646
Merged
Benjamin Christopher Simmonds (benibenj) merged 5 commits intoSep 1, 2026
Conversation
Contributor
Author
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Defers external-session discovery and reduces session-list invalidation to prevent Agent Host listing starvation.
Changes:
- Defers provider discovery until startup settles.
- Persists Recent-mode local-session cutoffs.
- Avoids invalidation for idle provisional sessions and updates tests/documentation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Updates Recent-mode description. |
src/vs/platform/agentHost/test/node/copilotAgent.test.ts |
Explicitly starts Copilot discovery. |
src/vs/platform/agentHost/test/node/codex/codexModelRefresh.test.ts |
Tests Codex discovery behavior; contains unresolved conflicts. |
src/vs/platform/agentHost/test/node/claudeAgent.test.ts |
Explicitly starts Claude discovery. |
src/vs/platform/agentHost/test/node/agentService.test.ts |
Covers discovery, cutoff persistence, and invalidation. |
src/vs/platform/agentHost/node/copilot/copilotAgent.ts |
Exposes explicit discovery startup. |
src/vs/platform/agentHost/node/codex/codexAgent.ts |
Tracks host-requested discovery across activation. |
src/vs/platform/agentHost/node/claude/claudeAgent.ts |
Exposes explicit discovery startup. |
src/vs/platform/agentHost/node/agentService.ts |
Coordinates deferred discovery and persisted recency state. |
src/vs/platform/agentHost/common/agentHostSchema.ts |
Updates Agent Host setting description. |
src/vs/platform/agentHost/common/agent.ts |
Adds the discovery-start API. |
src/vs/platform/agentHost/AGENTS.md |
Documents the revised discovery lifecycle. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
August 31, 2026 21:34
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Aug 31, 2026
Contributor
|
Base:
|
Preserve both the main-branch model resolution coverage and the cherry-picked host-requested discovery test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep active session-list scans coalesced and let stale callers share one trailing scan instead of starting overlapping provider, database, and Git work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 1, 2026
Report inactive Codex migration as deferred so AgentService does not latch an unrequested external discovery for the next activation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Sep 1, 2026
Alex Ross (alexr00)
approved these changes
Sep 1, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 1, 2026
9e59633
into
main
60 of 61 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
cherry-pick/333579
branch
September 1, 2026 10:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #333579 from
release/1.136.<<<<<<</=======/>>>>>>>) are committed to the branch — check it out locally, resolve, and force-push.Conflicting files:
src/vs/platform/agentHost/test/node/codex/codexModelRefresh.test.tsSummary
Addresses #333284.
Validation