Skip to content

fix(converter): print with the spec passed to convert_inner - #231

Open
tvanderstad wants to merge 2 commits into
mitex-rs:mainfrom
lockbook:travis/convert-inner-spec
Open

tvanderstad wants to merge 2 commits into
mitex-rs:mainfrom
lockbook:travis/convert-inner-spec

Conversation

@tvanderstad

Copy link
Copy Markdown

convert_math and convert_text accept a custom spec, use it for parsing, and don't use it for printing.

This PR:

  • Adds a (failing) test converting with a custom spec
  • Fixes it by using the passed spec for both parsing and printing

convert_inner parsed with the caller's spec but printed with DEFAULT_SPEC,
so a custom spec's aliases were ignored.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant