fix(models): allow newer model generations in dynamic model list - #1047
Merged
Merged
Conversation
The OpenAI and Anthropic allowlists were pinned to gpt-5 and claude-*-4, so self-hosted instances filtered out gpt-6 and Claude 5 models even when the provider API returned them. Match on generation number instead. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Self-hosted instances fetch the model list from each provider's API, then filter it with a hardcoded allowlist. The allowlist was pinned to
gpt-5*for OpenAI andclaude-{opus,sonnet,haiku}-4*for Anthropic, so newer models such asgpt-6-lunaand the Claude 5 family were dropped even when the API returned them.This switches both allowlists to match on generation number:
gpt-5and later, pluso1/o3/o4(older models such asgpt-4ostay excluded)opus/sonnet/haiku/fableat generation 4 and laterThe Gateway filter reuses the same functions, so
openai/...andanthropic/...models are covered too.Reported in #1040 (comment)
Test plan
gpt-6-lunaand Claude 5 models passing the filterbun run testbun format:check