Skip to content

add ego entry point (Issue #138) - #234

Open
jakob-r wants to merge 1 commit into
mainfrom
fix_138_entryPoints
Open

jakob-r wants to merge 1 commit into
mainfrom
fix_138_entryPoints

Conversation

@jakob-r

@jakob-r jakob-r commented Jun 7, 2016

Copy link
Copy Markdown
Member

No description provided.

@berndbischl

berndbischl commented Jun 7, 2016

Copy link
Copy Markdown
Member

lets us try to specify the API here:

  1. remove init.des.points. if not, the user has to tell the system HOW to gen the init design. blows up arg signature. let the user pass the des, if he does not, do a reasonable init des. i would suggest maxminLHS with 4*d.
  2. we need more simple term conditions. budget, iters, and a bound on the y value to reach.
  3. you need to check that parset only contains numerical stuff
  4. i dont think you can let the user pass a control object. i could use that do request "weird" stuff, non-ego stuff. if you want that, the full control, use mbo.
  5. its not "visible" how the learner is constructed. at least link to some doc page for this.

@mllg ?

@jakob-r

jakob-r commented Jun 8, 2016

Copy link
Copy Markdown
Member Author

For 5 see #223

@mllg

mllg commented Dec 23, 2016

Copy link
Copy Markdown
Member

We now have makeMBOLearner which approaches this very problem from a different angle. IMHO the construction of a default learner takes away most of the pain. I guess you cannot remove the burden of some choices from the user, like the termination criteria. Unsure how we should proceed.

I guess I would rather favor to postpone this one for now.

@berndbischl

Copy link
Copy Markdown
Member

I agree that this should be postponed!

But: makeMboLearner simply constructs a reasonable default model. This PR is about something else. And more general. Lets not mix the two.

@mllg mllg removed their assignment Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants