fix: only attach Java agent for injected server quick play - #7300
Closed
sarpedondev wants to merge 1 commit into
Closed
fix: only attach Java agent for injected server quick play#7300sarpedondev wants to merge 1 commit into
sarpedondev wants to merge 1 commit into
Conversation
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Member
|
Hi, I've gone through this and I don't think we'll accept this PR - while yes the java agent is fine to exclude when we are not doing quickplay, future app features we have planned will depend on the java agent, and besides there isn't really a reason to exclude it as it just brings in more complexity to the launching logic The surface area of the java agent is very small, do you have a link to any of the mods you're mentioning which have incompatibilities with the java agent? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Theseus Java agent was previously attached to every Minecraft launch, even though its transformer only modifies Minecraft when direct server quick play must be injected into an older game version.
This change attaches the agent only when launching a server with
QuickPlayServerVersion::Injected. It is no longer attached during ordinary launches or when using built-in, legacy command-line, singleplayer, or unsupported quick-play modes.Avoiding the unnecessary agent reduces compatibility issues with mods and loaders that inspect the JVM for active Java agents.
theseus.jarremains on the classpath because it is still required by the launch and RPC bootstrap. Direct server joining on affected older Minecraft versions continues to work.