Skip to content

feat(gdl): install gallery-dl nightly builds - #49

Open
IkariDevGIT wants to merge 8 commits into
monbooru:devfrom
IkariDevGIT:feature/42-gallery-dl-nightly
Open

IkariDevGIT wants to merge 8 commits into
monbooru:devfrom
IkariDevGIT:feature/42-gallery-dl-nightly

Conversation

@IkariDevGIT

Copy link
Copy Markdown

What it changes, and why:

  • The gallery-dl install field also takes nightly, for the newest build from gdl-org/builds, or a nightly's date such as 2026.11.12 to pin one. Blank still means the latest PyPI release, and release numbers work as before.
  • gdl-org tags its nightlies by build date and gallery-dl numbers its releases 1.x, so the two can't be confused. A date tag used to pass the release-number check and then fail on Codeberg and pip; it now goes to the nightly installer.
  • The download is checked against the sha256 digest GitHub publishes for the asset, since the release has no checksum file. It goes through the same capped, verified download as the stable one-file build.
  • The site list is read at the commit the nightly was built from (named in the release notes), from Codeberg. If no commit is named, the bundled copy seeds the site names, as on any other failed fetch.
  • Nightlies install on linux/amd64, windows/amd64 and windows/386, the platforms that already get the stable one-file build. Elsewhere the install is refused with "gdl-org publishes no nightly build for /" before anything is touched: pip has no nightly wheels to fall back to. gdl-org also publishes a macOS build, but which architecture it targets isn't clear, so it's left out.
  • The panel and its messages call the build "nightly 2026.11.12".

Two fixes found while testing, in their own commits:

  • The Stats section's gallery-dl version and extractor count only updated on a page reload. The install panel now sends them along each time it refreshes, so they change as soon as an install finishes.
  • With no gallery-dl left to run, for example after a revert with no bundled binary, the catalog cleared the version but kept the old extractor list. The list is now kept only while a binary still answers, or when the probe ran out of time.

Issue: #42

  • I reviewed every line of the diff and tested the change live.
  • The Go tests pass (go test ./...); new behaviour has a test where the package already has them.

@leqwin

leqwin commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

All good, I'll merge this for v1.15.0.

@leqwin leqwin added the accepted Wanted, no milestone yet. label Nov 13, 2026
@leqwin leqwin added this to the v1.15.0 milestone Nov 13, 2026
@leqwin leqwin linked an issue Nov 15, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted Wanted, no milestone yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support gallery-dl nightly builds

2 participants