fix: Preserve completed chunks when a batch geocoding chunk fails (closes #1932) - #1943
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Closed
botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
2 tasks
Collaborator
|
This PR appears to have been created by AI, as it ignores our PR template (resulting in failed check) |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Previously,
geocode_address_batchwould lose all successfully geocoded chunks if any subsequent chunk raised an exception (e.g., a transient network error). On large tables this could mean hours of work lost.Fix
Wrap each chunk's geocoding call in a try/except. On failure, log a warning and return the partial results collected so far instead of raising and discarding everything. This preserves the completed portion and lets the caller decide how to handle incomplete data.
Closes #1932