Skip to content

[wontfix,not-planned] Add marquee zoom with a previous zoom restore button - #22071

Closed
kairosci wants to merge 1 commit into
mozilla:masterfrom
kairosci:feature/marquee-zoom
Closed

kairosci wants to merge 1 commit into
mozilla:masterfrom
kairosci:feature/marquee-zoom

Conversation

@kairosci

@kairosci kairosci commented Oct 4, 2026 •

Copy link
Copy Markdown
preview.mp4

Closes #1260.

Related to #20562.

@kairosci
kairosci requested a review from a team as a code owner October 4, 2026 22:06
@codecov-commenter

codecov-commenter commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.52239% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.30%. Comparing base (35f87e3) to head (d061c16).

Files with missing lines Patch % Lines
web/zoom_to_rect.js 95.06% 4 Missing ⚠️
web/app.js 94.11% 1 Missing ⚠️
web/zoom_restore_button.js 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22071      +/-   ##
==========================================
- Coverage   90.30%   90.30%   -0.01%     
==========================================
  Files         269      271       +2     
  Lines       67371    67504     +133     
==========================================
+ Hits        60838    60958     +120     
- Misses       6533     6546      +13     
Flag Coverage Δ
browsertest 66.05% <ø> (-0.01%) ⬇️
integrationtest 69.31% <95.52%> (+0.06%) ⬆️
unittest 59.85% <ø> (-0.02%) ⬇️
unittestcli 58.37% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kairosci
kairosci force-pushed the feature/marquee-zoom branch from e1862dc to d061c16 Compare October 4, 2026 22:23
@kairosci

kairosci commented Oct 4, 2026 •

Copy link
Copy Markdown
Author

Manually tested rectangle zoom, previous zoom restoration, cancellation with Esc, and link handling. Also verified rotation, page switching, sidebar, document switching, and button readability in light and dark themes. The existing viewer features continue to work; no regressions were found during the tests performed.

If you want, I can send you video proof of each one :)

@flodolo flodolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is clearly marked as "needs feedback".

Adding new features requires UX/Content/Product guidance.

Taking out of the review queue for now.

@kairosci

kairosci commented Oct 5, 2026

Copy link
Copy Markdown
Author

@Snuffleupagus why?

@kairosci kairosci changed the title Add marquee zoom with a previous zoom restore button [wontfix,not-planned] Add marquee zoom with a previous zoom restore button Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marquee Zoom Feature

4 participants