Repository navigation
Support flattening in Firefox save events (bug 2075337) - #22449
Open
calixteman wants to merge 5 commits into
Open
calixteman wants to merge 5 commits into
calixteman wants to merge 5 commits into
Conversation
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Nov 4, 2026
Contributor
Viewer previewCommit 6e70b5f (build logs).
Previews are removed when the PR closes and may be pruned after 30 days without an update. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22449 +/- ##
==========================================
+ Coverage 90.57% 90.63% +0.06%
==========================================
Files 276 277 +1
Lines 68671 69309 +638
==========================================
+ Hits 62197 62819 +622
- Misses 6474 6490 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 1.93%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
calixteman
force-pushed
the
flatten-firefox-save
branch
from
November 4, 2026 20:51
dfad087 to
0b1c7a5
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Nov 4, 2026
Add flatten and intent options to draw supported annotation appearances into page content. Use print or display visibility. Keep the widgets and the interactive annotations. Android 14's PdfRenderer calls PDFium without FPDF_ANNOT [1]. [1] https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-14.0.0_r1/libs/hwui/jni/pdf/PdfRenderer.cpp
With `flatten: true`, also draw the widgets, generating their appearances from the stored values, and remove the ones hidden for the intent. Prune the removed fields from the AcroForm, and remove it when no page widget remains, unless it declares signatures. Add a "non-forms" value to keep the form fields.
In a flat parent tree, replace the OBJR of a flattened annotation with a marked-content reference to its drawing in the page content. For other readable parent trees, only remove the OBJR.
Reuse the save path to flatten extracted pages. Remap pending form edits to copied annotations and reload with the encryption source's password. Rebuild the PDF to discard the unflattened revision.
Forward flatten and intent through saving and extraction, including unedited PDFs. Run WillPrint/DidPrint for print flattening.
calixteman
force-pushed
the
flatten-firefox-save
branch
from
November 9, 2026 21:07
0b1c7a5 to
6e70b5f
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Nov 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward flatten and intent through saving and extraction, including unedited PDFs. Run WillPrint/DidPrint for print flattening.