Repository navigation
Start loading the viewer icons earlier in Firefox - #22457
Conversation
Viewer preview🗑️ Viewer previews removed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22457 +/- ##
==========================================
- Coverage 90.54% 88.61% -1.94%
==========================================
Files 276 276
Lines 68557 73573 +5016
==========================================
+ Hits 62077 65198 +3121
- Misses 6480 8375 +1895
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 8.13%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
The CSS only fetches an icon once its element is rendered, so the toolbar is first painted without icons and the menus load theirs when first opened. Preload the toolbar icons from viewer.html (without crossorigin, since CSS images from resource:// are fetched without CORS), and warm the image cache up with the icons of the hidden UI once the first page is rendered.
a8307da to
ce31961
Compare
|
Looks good like this; thank you! |
The CSS only fetches an icon once its element is rendered, so the toolbar is first painted without icons and the menus load theirs when first opened.
Preload the toolbar icons from viewer.html (without crossorigin, since CSS images from resource:// are fetched without CORS), and warm the image cache up with the icons of the hidden UI once the first page is rendered.