Skip to content

Look up the space glyph in ToUnicode by string in Font.spaceWidth #22474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayhemnani9910 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Look up the space glyph in ToUnicode by string in Font.spaceWidth #22474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/core/fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3602,8 +3602,11 @@ class Font {
}
}
// ... via toUnicode map
if (!charcode && this.toUnicode) {
charcode = this.toUnicode.charCodeOf(glyphUnicode);
if (!charcode && this.toUnicode && glyphUnicode !== undefined) {
charcode =
this.toUnicode instanceof IdentityToUnicodeMap
? this.toUnicode.charCodeOf(glyphUnicode)
: this.toUnicode.charCodeOf(String.fromCodePoint(glyphUnicode));
}
// setting it to unicode if negative or undefined
if (charcode <= 0) {
Expand Down
1 change: 1 addition & 0 deletions test/pdfs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,7 @@
!issue18768_text_matrix_spacing.pdf
!issue18768_type3_wide_glyph.pdf
!issue18768_word_spaces.pdf
!tounicode_space_width.pdf
!issue19954_reduced.pdf
!issue1936_reduced.pdf
!issue22462.pdf
Binary file added test/pdfs/tounicode_space_width.pdf
View file
Open in desktop
Binary file not shown.
15 changes: 15 additions & 0 deletions test/unit/api_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5370,6 +5370,21 @@ ABCD E`);
await loadingTask.destroy();
});

it("gets text content, using the ToUnicode space width for letter-spaced text", async function () {
const loadingTask = getDocument(
buildGetDocumentParams("tounicode_space_width.pdf")
);
const pdfDoc = await loadingTask.promise;
const pdfPage = await pdfDoc.getPage(1);
const { items } = await pdfPage.getTextContent({
disableNormalization: true,
});

expect(mergeText(items)).toEqual("TRACK TACK");

await loadingTask.destroy();
});

it("gets text content, preserving various word spaces", async function () {
const loadingTask = getDocument(
buildGetDocumentParams("issue18768_word_spaces.pdf")
Expand Down