Repository navigation
Limit all defaultRenderingQueue logic in PDFViewer to GENERIC builds - #22479
Merged
Snuffleupagus merged 1 commit intoNov 8, 2026
Conversation
Avoid bundling dead code in the Firefox PDF Viewer, since it already can't work without a `renderingQueue` option provided.
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Nov 8, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22479 +/- ##
==========================================
- Coverage 90.57% 90.55% -0.02%
==========================================
Files 276 276
Lines 68665 68666 +1
==========================================
- Hits 62190 62183 -7
- Misses 6475 6483 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Nov 8, 2026
timvandermeij
left a comment
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with passing CI. Thank you!
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid bundling dead code in the Firefox PDF Viewer, since it already can't work without a
renderingQueueoption provided.