Repository navigation
Fix the measurement of b and i elements in XFA rich text - #22485
Conversation
`TextMeasure` has no `pushFont` method, so laying out any rich text containing a <b> or an <i> threw and no page was rendered. It fixes mozilla#22023.
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22485 +/- ##
==========================================
- Coverage 90.57% 90.57% -0.01%
==========================================
Files 276 276
Lines 68666 68661 -5
==========================================
- Hits 62195 62189 -6
- Misses 6471 6472 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 1.55%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
Reference testsResults for 5a7a44d (run, references from mozilla/pdf.js.refs@039b06e737).
The report is kept for 30 days and replaced by the next run. |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing browser tests. Thank you for fixing this!
TextMeasurehas nopushFontmethod, so laying out any rich text containing a or an threw and no page was rendered.It fixes #22023.