Skip to content

Enable "large window" support in the Brotli JS decoder (issue 22487) - #22490

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22487
Nov 10, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:issue-22487

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

While the Brotli decoder does contain an enableLargeWindow function, it however does not currently expose any option for it. Note that according to this document, a Brotli decoder needs to have "large window" support.

Hence, until an option is exposed upstream, we can patch that in via the "release-brotli" gulp task.

While the Brotli decoder does contain an `enableLargeWindow` function, it however does *not* currently expose any option for it. Note that according to [this document](https://pdfa.org/download-area/publications/pdf-extension-brotli.pdf#%5B%7B%22num%22%3A224%2C%22gen%22%3A0%7D%2C%7B%22name%22%3A%22XYZ%22%7D%2C51.023%2C538.141%2Cnull%5D), a Brotli decoder needs to have "large window" support.

Hence, until an option is exposed upstream, we can patch that in via the "release-brotli" gulp task.
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 28aaa49 (run, references from mozilla/pdf.js.refs@bd806597eb).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1420 12m 49s 0 1 0 1 view differences
Windows ⚠️ 1420 16m 52s 0 0 0 1

The report is kept for 30 days and replaced by the next run.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 9, 2026
Comment thread gulpfile.mjs Dismissed
@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (b600aec) to head (28aaa49).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22490      +/-   ##
==========================================
- Coverage   90.58%   90.56%   -0.02%     
==========================================
  Files         276      276              
  Lines       68671    68672       +1     
==========================================
- Hits        62203    62196       -7     
- Misses       6468     6476       +8     
Flag Coverage Δ
fonttest 9.09% <ø> (ø)
integrationtest 69.66% <0.00%> (-0.02%) ⬇️
unittest 63.10% <100.00%> (+<0.01%) ⬆️
unittestcli 60.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 9, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit 4fb6ee6 into mozilla:master Nov 10, 2026
29 of 30 checks passed
@Snuffleupagus
Snuffleupagus deleted the issue-22487 branch November 10, 2026 13:54
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 10, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — 28aaa490 Deployed Nov 9, 2026 by Snuffleupagus via request #783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: JavaScript Brotli fallback rejects required large-window PDF streams (patch included)

4 participants