[Snuffleupagus]

Currently there's a fair number of catch handlers that just suppress "uncaught exceptions", and rather than creating potentially a lot of inline functions we can re-use just a single helper instead.

Note that such a function already existed, in the src/shared/message_handler.js file, hence that one is simply moved and re-named.

[github-actions]

Reference tests

Results for 30c5523 (run, references from mozilla/pdf.js.refs@70a2e10bb1).

Platform	Status	Tests	Total runtime	Errors	Different	FBF	No reference	Report
	✅	1420	13m 41s	0	0	0	0
	✅	1420	17m 14s	0	0	0	0

The report is kept for 30 days and replaced by the next run.

[github-actions]

Viewer preview

🗑️ Viewer previews removed.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.57%. Comparing base (cf5e897) to head (30c5523).

Files with missing lines	Patch %	Lines
src/core/editor/pdf_images.js	0.00%	1 Missing ⚠️
src/display/api.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #22511   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files         276      276           
  Lines       68676    68676           
=======================================
+ Hits        62196    62200    +4     
+ Misses       6480     6476    -4     

Flag	Coverage Δ
fonttest	9.08% <0.00%> (ø)
integrationtest	69.67% <73.33%> (+<0.01%)	⬆️
unittest	63.10% <66.66%> (+<0.01%)	⬆️
unittestcli	60.68% <62.50%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codspeed]

Merging this PR will degrade performance by 3.38%

1 warning

⚠️ 2 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 86 untouched benchmarks
⏩ 174 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	Autolinker.processLinks: 2 links in each of 5000 text items	65.9 ms	78.5 ms	-16.06%
⚡	MetadataParser: XMP (issue11144_reduced.pdf)	4.9 ms	4.4 ms	+11.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing Snuffleupagus:catch-noopFn (30c5523) with master (cf5e897)}

Footnotes

1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[nicolo-ribaudo]

Some other places where it can be used:

pdf.js/src/display/api.js

Lines 2179 to 2182 in cf5e897

	this.#messageHandler.on("ready", () => {
	// Ignoring "ready" event -- MessageHandler should already be initialized
	// and ready to accept messages.
	});

pdf.js/src/core/parser.js

Line 276 in cf5e897

tmpLexer._hexStringWarn = () => {};

pdf.js/web/app.js

Line 2839 in cf5e897

this._unblockDocumentLoadEvent = () => {};