Skip to content

Preserve stamp orientation and size when editing saved annotations - #22517

Open
calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:stamp-rotated-edit
Open

calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:stamp-rotated-edit

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Use the annotation rotation when extracting its bitmap, and keep the rotation-aware dimensions from AnnotationEditor.deserialize.

Use the annotation rotation when extracting its bitmap, and keep the
rotation-aware dimensions from AnnotationEditor.deserialize.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

Commit 235187e (build logs).

Viewer Build Preview
Modern (gulp generic) ✅ viewer.html
Legacy (gulp generic-legacy) ✅ viewer.html

Previews are removed when the PR closes and may be pruned after 30 days without an update.

@codecov-commenter

codecov-commenter commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (7a4022e) to head (235187e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22517      +/-   ##
==========================================
+ Coverage   90.37%   90.39%   +0.02%     
==========================================
  Files         276      276              
  Lines       69938    69938              
==========================================
+ Hits        63207    63221      +14     
+ Misses       6731     6717      -14     
Flag Coverage Δ
fonttest 9.08% <ø> (ø)
integrationtest 71.43% <100.00%> (+0.23%) ⬆️
unittest 63.10% <0.00%> (+<0.01%) ⬆️
unittestcli 60.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 13, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.98%

⚡ 4 improved benchmarks
✅ 84 untouched benchmarks
⏩ 174 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ PartialEvaluator.buildPath: lines (bug1743245.pdf) 16.7 ms 14.4 ms +16.03%
⚡ getUnicodeRangeFor (bug1473809.pdf) 26.8 ms 23.8 ms +12.51%
⚡ PDFPageProxy.render: luminosity soft mask (issue18956.pdf) 22.8 ms 20.3 ms +12.19%
⚡ Autolinker.processLinks: 2 links in each of 5000 text items 76.8 ms 69.1 ms +11.23%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:stamp-rotated-edit (235187e) with master (7a4022e)2

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (0471653) during the generation of this report, so 7a4022e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants