cache: avoid duplicate multilevel reads - #2835
Open
zfaustk wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
- Coverage 73.82% 72.24% -1.58%
==========================================
Files 72 72
Lines 38087 39257 +1170
==========================================
+ Hits 28117 28362 +245
- Misses 9970 10895 +925 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2817
When a lower cache level had a hit,
MultiLevelStoragefetched the object once to parse it and again to backfill faster levels. This change lets raw-capable backends return the parsed cache entry and its bytes together, so the same object is read only once. Backends without the override keep the existing behavior.The focused multilevel regression passes, along with
cargo fmt -- --checkand the required locked clippy command. The full locked library/binary/test suite is left to CI because an unchanged macOS integration helper aborts while loading a libc function pointer on this host.