Repository navigation
Fix OIBH to Bahregan and remove duplicate OI20 - #235
Merged
Merged
Conversation
Collaborator
|
Nice thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234.
OIBHis Bahregan, not Bastak. The row carried the correctiatavalue and the wrongname,state,lat,lonandelevation.OI20held the real Bahregan data under an OurAirports placeholder code. This PR moves that data ontoOIBHand removesOI20, which then duplicates it.Two entries change. The file drops from 29,308 to 29,307 rows. No other row moves.
Evidence
ICAO Doc 7910 is the authority for location indicators. Edition 132 gives this in the
OI - IRAN (ISLAMIC REPUBLIC OF)block:ICAO assigns
OIBHto Bahregan. The IATA codeIAQsits on the same row. That edition holds no entry for Bastak, in theOIdecode block or in the alphabetical location index.SkyVector, FlightAware, Wikidata Q3448885, OpenStreetMap way/733568330 and both the English and Persian Wikipedia articles all agree. Issue #234 gives the full table.
OurAirports is the source of the old pairing. Several airport directories repeat it, but they all share the OurAirports lineage.
Field notes
cityasEmam Hasanfollows the house style of the file, which strips diacritics. OurAirports spells the municipality "Imam Hassan".latandloncome from the oldOI20row. They agree with SkyVector, Wikidata and OpenStreetMap to a few hundred metres. The Wikipedia infobox gives50|58|33|E, which is a typo for50|16|33|E, so I did not use it.elevationstays at the 20 ft of the oldOI20row. SkyVector gives 32 ft instead. No source settles it, so I kept the value already in the file. Tell me if you prefer 32.Checks
.github/scripts/valid_json.pypasses..github/scripts/sort.pyoutput is byte-identical to the committed file.