Repository navigation
Cocos (Keeling) Islands - Adjust holidays - #1183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements to the handling and testing of public holidays for the Cocos (Keeling) Islands. The main changes include enhanced logic for holiday observation rules, the addition of special cases (notably for the Monarch's Birthday), and the introduction of a dedicated unit test class to verify holiday calculations. These updates ensure greater accuracy and maintainability of the holiday provider.
Enhancements to holiday observation logic:
ObservedRuleSetconfigurations inCocosIslandsHolidayProviderto handle shifting holidays when they fall on weekends or overlap with other holidays, including a custom rule for Self Determination Day and a special case for the Monarch's Birthday in 2025 [1] [2] [3] [4].Special handling for Monarch's Birthday:
Testing improvements:
CocosIslandsTestwith detailed test cases for all major public holidays, ensuring correct calculation and observation for years 2021–2027.Documentation and source updates: