Repository navigation
fix: stop dataset mismatch alert from flashing during autodetection - #1850
Merged
Merged
Conversation
…detection - The run state became done when the worker finished streaming per-sequence results, but the best datasets arrived only after a further worker call, so for that interval the suggestion alerts read the run as finished without suggestions and showed the red "No matching datasets" alert - Commit the best datasets and the done state together, after the worker has delivered every result, so that no component observes a finished run with an incomplete outcome - Terminate the autodetection Web Worker after each run, because each run spawns a new worker and freeing only its WebAssembly module left the worker alive
ivan-aksamentov
force-pushed
the
fix/autodetect-error-blink
branch
from
November 3, 2026 03:00
1b703ed to
c9ea5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
✨ Claude Opus 5.5 is writing on behalf of Ivan
Change: Mark a dataset autodetection run as done only together with its suggestions [src].
Context: The run became done when the worker finished streaming per-sequence results, but the suggestions arrived from a later worker call. In between, the main page and the dataset page briefly showed the red "Possible dataset mismatch detected" or "No matching datasets" alert, even for matching sequences.
Work items