Repository navigation
Ebola resources page - #1400
Open
jameshadfield wants to merge 3 commits into
Open
Ebola resources page#1400jameshadfield wants to merge 3 commits into
jameshadfield wants to merge 3 commits into
Conversation
jameshadfield
temporarily deployed
to
nextstrain-s-ebola-page-axuvrp
October 19, 2026 00:13
Inactive
victorlin
approved these changes
Oct 19, 2026
victorlin
reviewed
Oct 19, 2026
Comment on lines
+60
to
+65
| * Core build paths whose bare URL (e.g. `/ebola`) should _not_ be handled here | ||
| * but instead fall through to the Next.js static site, which serves a bespoke | ||
| * landing page at that path. | ||
| */ | ||
| const staticPagePaths = new Set([ | ||
| "/ebola", |
Member
There was a problem hiding this comment.
+1 for this pattern instead of /sars-cov-2 vs. /ncov. I always found that a bit weird.
joverlee521
reviewed
Oct 19, 2026
| * landing page at that path. | ||
| */ | ||
| const staticPagePaths = new Set([ | ||
| "/ebola", |
Contributor
There was a problem hiding this comment.
I was able to find references to /ebola in GH search and the /pathogens page also uses the default link.
Thoughts on using a different path, e.g./ebola-resources, instead of replacing the default /ebola URL?
Member
Author
There was a problem hiding this comment.
Thanks for digging here! I think all of those are resolvable (and should be done as part of this). I agree with Victor's comment above; where we have lots of foo/* builds I think having a splash page at /foo makes the most sense.
Closes <#1389> Claude Opus 4.8 helped write the tiles list component code. All text & design decisions were mine.
This reverts commit 0cbdbc8. Recommended in PR review <#1400 (comment)>
jameshadfield
force-pushed
the
ebola-page
branch
from
October 20, 2026 02:39
f0b657d to
298b4f5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1389
Review app main splash page
Review app /ebola splash page