Repository navigation
Merge main into adobe-public (zlib fix) - #111
Merged
Merged
Conversation
Add SPZ_NIANTIC_georeference extension (vendor ID 0x4E53) Stores a similarity transform (origin, unit quaternion, scale) from the asset's RUB frame into a geocentric CRS, given as AUTHORITY:CODE (e.g. EPSG:4978) or inline PROJJSON for non-Earth bodies, with an optional coordinate epoch. The library validates the record but never applies it. Adds SpzExtensionBase::isValid() (default true); saveSpz now fails if any extension is invalid. Includes Python/WASM bindings, docs and tests. Co-authored-by: Diego <diego@nianticspatial.com>
…107) * first pass * fix wasm custom attribute conversion * decode filter * fix test number * update quantized bits to 16 * add test
zlib.net only serves the latest release at the top level and moves older ones to /fossils/, so https://zlib.net/zlib-1.3.2.tar.gz now 404s and any build without a system zlib fails at configure time. Same tarball, so the URL_HASH is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings #110 (zlib fetched from
zlib.net/fossils) intoadobe-public. Without it,v3.0.0+adobe.34fails to build on machines without a system zlib, because the oldzlib.net/zlib-1.3.2.tar.gzURL returns 404.Heads-up on how to land this: this repo only allows squash merges, and a squash would drop the part that matters most here. #109 was squashed, so git doesn't know
adobe-publicalready containsmain's commits. A plain merge ofmainconflicts in 15 files, even though the contents are identical.This branch's merge commit (
0764e8c) hasmain(8551739) as a second parent, which fixes that for every later sync. Every conflict resolves toadobe-public's existing content, and the only content change is #110's one line. To keep it, fast-forwardadobe-publicto0764e8conce CI passes (the old "Merge branch 'main' into adobe-public" commits were pushed this way), and close this PR. Squashing works for the zlib fix but leaves the next sync conflicting again.Checked: after this merge,
mainis an ancestor ofadobe-public, andadobe-publicdiffers frommainonly by the environment map (#106, 25 files).Next: tag
v3.0.0+adobe.35on the result.