Repository navigation
Conversation
nisamson
marked this pull request as ready for review
October 8, 2026 18:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shuttle-shl/shl-games-archiverepository, using Key Vault credentials and in-process LibGit2Sharp.Shuttle.GameArchiveand add a one-shot local runner with an isolated AspireArchiveOnlyprofile, persistent Gitea, and a Key Vault emulator; no API, SQL, or Azure login is needed..csvsource files with case-insensitive matching, excluding every other extension and extensionless files. Previously managed non-CSV files are removed only after eligible downloads succeed; unmanaged files, the root README, generated manifest, and historical commits are preserved.manifest.jsonwith a formal JSON Schema, ordinal path ordering, fixed property order, and stable LF formatting.NuGetAuditSuppressentries for the five known ImageSharp advisories only in the non-production Vision tool and its tests. NuGet Audit and warnings-as-errors remain enabled, with no exceptions in the deployed API/WebClient. Document the accepted local risk and removal on upgrade.Validation
.csv.zip. Excluded entries still undergo path/collision checks, and directory names never determine eligibility. A Git regression verifies non-CSV files are never downloaded, failed eligible downloads preserve excluded managed files, successful runs remove only owned files, history remains intact, and ignored-content changes cause no commit.Shuttle.Testsproject passes in a clean worktree, excluding unrelated staged FHM changes.dotnet test --verbosity minimal -maxcpucount:1 -p:BuildInParallel=false(561 main, 202 bUnit, 6 E2E, 74 Vision). Serialized builds avoid an observed concurrent Blazor static-assets cache lock.Production activation
This PR does not deploy or populate credentials. Bootstrap infrastructure/RBAC with
FIRST_RUN=true, put the repository-scoped bot PAT directly in Key Vault, assess backfill capacity, and verify the first production snapshot. The production AppHost enables the archive by default; it can be paused withArchive:Enabled=false.Custom HTML indexes remain intentionally excluded. The discussed Polly resilience policy is not implemented here; existing retry behavior is retained. No legacy manifest migration is included because the archive has not yet been deployed.