Skip to content

fix(history): replay a multiline batch with its sender as the BATCH source - #36

Merged
matheusfillipe merged 1 commit into
unreal60_devfrom
fix/history-multiline-batch-source
Oct 23, 2026
Merged

matheusfillipe merged 1 commit into
unreal60_devfrom
fix/history-multiline-batch-source

Conversation

@matheusfillipe

Copy link
Copy Markdown

After a reload, multiline messages fetched through CHATHISTORY showed the server name as their author, because the replayed draft/multiline BATCH was opened and closed with the server as its source while the lines inside kept the real sender. Clients name a multiline message after the BATCH source, as the multiline spec defines it, so the replay now opens and closes the batch with the sender from its first stored line, the same as live delivery.

flowchart LR
  A["before: :irc.example BATCH +id draft/multiline #room"] --> B["after: :nick!user@host BATCH +id draft/multiline #room"]
Loading

An e2e test replays a multiline message and checks the BATCH open and close lines name the sender.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0b1a9118-06e9-4d55-8957-3994cbabe5f8
📥 Commits

Reviewing files that changed from the base of the PR and between 4dadaa5 and 1f9e02b.

📒 Files selected for processing: 2
  • src/api-history-backend.c
  • tests/e2e/test_history_multiline.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matheusfillipe
matheusfillipe merged commit 01158f9 into unreal60_dev Oct 23, 2026
8 checks passed
@matheusfillipe
matheusfillipe deleted the fix/history-multiline-batch-source branch October 23, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants