Skip to content

feat(settings): settings as pages and server notices - #302

Open
matheusfillipe wants to merge 4 commits into
stack/mobilefrom
stack/pages
Open

matheusfillipe wants to merge 4 commits into
stack/mobilefrom
stack/pages

Conversation

@matheusfillipe

@matheusfillipe matheusfillipe commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor
  • Server errors go to Server Notices with a badge
  • Settings dialogs become pages, plus a profile pane
  • Settings save themselves
  • One embed player that keeps its place
  • YouTube plays in the installed apps

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 164 files, which is 64 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5ff739e-4867-4401-9648-4dbc74273f74

📥 Commits

Reviewing files that changed from the base of the PR and between 8993adc and 53b0b7a.


⛔ Files ignored due to path filters (1)
  • src-tauri/gen/apple/Obby_iOS/Info.plist is excluded by !**/gen/**

📒 Files selected for processing (164)
  • src-tauri/Info.plist
  • src-tauri/src/lib.rs
  • src-tauri/src/youtube_player.rs
  • src-tauri/youtube-embed.html
  • src/App.tsx
  • src/components/layout/AppLayout.tsx
  • src/components/layout/ChannelList.tsx
  • src/components/layout/ChatArea.tsx
  • src/components/layout/ChatHeader.tsx
  • src/components/layout/ConnectionStrip.tsx
  • src/components/layout/MemberList.tsx
  • src/components/layout/NetworkMenu.tsx
  • src/components/layout/ProfilePane.tsx
  • src/components/layout/ServerList.tsx
  • src/components/layout/SidePane.tsx
  • src/components/layout/VoiceChannelView.tsx
  • src/components/message/EmbedPlayer.tsx
  • src/components/message/MediaPreview.tsx
  • src/components/mobile/MessageReaderSheet.tsx
  • src/components/pages/BotsPage.tsx
  • src/components/pages/ChannelBrowserPage.tsx
  • src/components/pages/ChannelSettingsPage.tsx
  • src/components/pages/EmojiPacksPage.tsx
  • src/components/pages/PageHost.tsx
  • src/components/pages/RawLogPage.tsx
  • src/components/pages/ServerSettingsPage.tsx
  • src/components/pages/SettingsPage.tsx
  • src/components/pages/TwoFactorPage.tsx
  • src/components/pages/pageSections.tsx
  • src/components/ui/AttachmentTray.tsx
  • src/components/ui/BlankPage.tsx
  • src/components/ui/BotsModal.tsx
  • src/components/ui/BouncerDisconnectConfirmModal.tsx
  • src/components/ui/BouncerNetworkDisconnectConfirmModal.tsx
  • src/components/ui/CameraCaptureModal.tsx
  • src/components/ui/ChangePasswordModal.tsx
  • src/components/ui/ChannelListModal.tsx
  • src/components/ui/ChannelSettingsModal.tsx
  • src/components/ui/EditServerModal.tsx
  • src/components/ui/EmojiPackAdminModal.tsx
  • src/components/ui/EmojiPickerModal.tsx
  • src/components/ui/FloodSettingsModal.tsx
  • src/components/ui/GifSelector.tsx
  • src/components/ui/GlobalNotifications.tsx
  • src/components/ui/HomeScreen.tsx
  • src/components/ui/LinkSecurityWarningModal.tsx
  • src/components/ui/MediaCommentsSidebar.tsx
  • src/components/ui/MediaViewerModal.tsx
  • src/components/ui/MiniMediaPlayer.tsx
  • src/components/ui/ObbyWhoisModal.tsx
  • src/components/ui/PasswordRecoveryModal.tsx
  • src/components/ui/ProfileModalRouter.tsx
  • src/components/ui/QuickActions.tsx
  • src/components/ui/QuickActions/pageTargets.ts
  • src/components/ui/QuickActions/types.ts
  • src/components/ui/QuickActions/uiActionConfig.tsx
  • src/components/ui/RawLogViewer.tsx
  • src/components/ui/ReactionModal.tsx
  • src/components/ui/SlashCommandParamModal.tsx
  • src/components/ui/StandardReplyNotification.tsx
  • src/components/ui/TextInput.tsx
  • src/components/ui/TicTacToeModal.tsx
  • src/components/ui/TotpStepUpModal.tsx
  • src/components/ui/TwoFactorSettingsModal.tsx
  • src/components/ui/UserContextMenu.tsx
  • src/components/ui/UserProfileModal.tsx
  • src/components/ui/UserSettings.tsx
  • src/components/ui/page/PageShell.tsx
  • src/components/ui/page/SettingRow.tsx
  • src/components/ui/settings/SettingRenderer.tsx
  • src/index.css
  • src/lib/fuzzySearch.ts
  • src/lib/irc/IRCClient.ts
  • src/lib/ircUtils.tsx
  • src/lib/mediaUtils.ts
  • src/lib/messageFormatter.ts
  • src/lib/messageGrouping.ts
  • src/lib/modal/BaseModal.tsx
  • src/lib/modal/components/Button.tsx
  • src/lib/modal/components/Input.tsx
  • src/lib/modal/components/ModalBody.tsx
  • src/lib/modal/components/ModalFooter.tsx
  • src/lib/settings/definitions/allSettings.ts
  • src/lib/settings/registry.ts
  • src/locales/cs/messages.mjs
  • src/locales/cs/messages.po
  • src/locales/de/messages.mjs
  • src/locales/de/messages.po
  • src/locales/en/messages.mjs
  • src/locales/en/messages.po
  • src/locales/es/messages.mjs
  • src/locales/es/messages.po
  • src/locales/fi/messages.mjs
  • src/locales/fi/messages.po
  • src/locales/fr/messages.mjs
  • src/locales/fr/messages.po
  • src/locales/it/messages.mjs
  • src/locales/it/messages.po
  • src/locales/ja/messages.mjs
  • src/locales/ja/messages.po
  • src/locales/ko/messages.mjs
  • src/locales/ko/messages.po
  • src/locales/nl/messages.mjs
  • src/locales/nl/messages.po
  • src/locales/pl/messages.mjs
  • src/locales/pl/messages.po
  • src/locales/pt/messages.mjs
  • src/locales/pt/messages.po
  • src/locales/ro/messages.mjs
  • src/locales/ro/messages.po
  • src/locales/ru/messages.mjs
  • src/locales/ru/messages.po
  • src/locales/sv/messages.mjs
  • src/locales/sv/messages.po
  • src/locales/tr/messages.mjs
  • src/locales/tr/messages.po
  • src/locales/uk/messages.mjs
  • src/locales/uk/messages.po
  • src/locales/zh-TW/messages.mjs
  • src/locales/zh-TW/messages.po
  • src/locales/zh/messages.mjs
  • src/locales/zh/messages.po
  • src/store/handlers/connection.ts
  • src/store/handlers/index.ts
  • src/store/handlers/serverReplies.ts
  • src/store/handlers/users.ts
  • src/store/index.ts
  • src/store/types.ts
  • tests/App.test.tsx
  • tests/components/CameraCaptureModal.test.tsx
  • tests/components/ChannelListModal.test.tsx
  • tests/components/ChatArea.test.tsx
  • tests/components/HomeScreen.icon.test.ts
  • tests/components/LinkSecurityWarningModal.test.tsx
  • tests/components/MetadataDisplay.test.tsx
  • tests/components/ModerationModal.test.tsx
  • tests/components/ServerSettingsPage.test.tsx
  • tests/components/StandardReplyNotification.test.tsx
  • tests/components/UserSettings.test.tsx
  • tests/components/layout/AppLayout.mobile-init.test.tsx
  • tests/components/layout/AppLayout.resize.test.tsx
  • tests/components/layout/AppLayout.test.tsx
  • tests/components/layout/ChatHeader.memberButton.test.tsx
  • tests/components/layout/ChatHeader.privateChat.test.tsx
  • tests/components/layout/ConnectionStrip.test.tsx
  • tests/components/layout/ProfilePane.test.tsx
  • tests/components/layout/StartPrivateChatRow.test.tsx
  • tests/components/message/EmbedPlayer.test.tsx
  • tests/components/pages/BotsPage.test.tsx
  • tests/components/pages/ChannelBrowserPage.test.tsx
  • tests/components/pages/ChannelSettingsPage.test.tsx
  • tests/components/pages/SettingsPage.test.tsx
  • tests/components/ui/PageShell.test.tsx
  • tests/fixtures/uiState.ts
  • tests/lib/appYouTubeEmbed.test.ts
  • tests/lib/fuzzySearch.test.ts
  • tests/lib/irc/multilineConcat.test.ts
  • tests/lib/messageFormatter.test.ts
  • tests/lib/messageGrouping.test.ts
  • tests/lib/nicknameRetry.test.ts
  • tests/protocol/mode.test.ts
  • tests/store/index.test.ts
  • tests/store/pageNavigation.test.ts
  • tests/store/serverReplies.test.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matheusfillipe
matheusfillipe added this pull request to stack #305 October 10, 2026 18:36
@github-actions

Copy link
Copy Markdown

Pages Preview
Preview URL: https://stack-pages.obsidianirc.pages.dev

Automated deployment preview for the PR in the Cloudflare Pages.

@matheusfillipe matheusfillipe changed the title feat(settings): notices, pages and youtube feat(settings): settings as pages and server notices Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants