Repository navigation
fix(components): the row's leading cell is the selection's hit area (objectui#13016) - #13018
Merged
Merged
Conversation
…so a near miss on the checkbox no longer opens the record (objectui#13016) On a tall row the 16px checkbox is a small target. A click beside it bubbled to the row's onRowClick and navigated to the record detail. The leading cell now toggles the row's selection on any click that is not on the checkbox itself, and the row's click filter skips it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV4S9ReSgn5hj61n1VbimV
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
…he first (objectui#13016) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XV4S9ReSgn5hj61n1VbimV
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes objectui#13016
What
On list views with tall rows, the row-select checkbox (16px) is hard to hit, and a click beside it bubbled to
onRowClickand opened the record detail.data-slot="row-leading-cell") now toggles the row's selection on any click that is not on the checkbox itself, and showscursor-pointer.Tests
New
data-table-leadingCellHitArea-13016.test.tsx, run with and without row numbers: a click beside the checkbox selects/deselects without opening; a click on the checkbox toggles once; a data-cell click still opens. The near-miss case fails without the fix (2 failures) and passes with it. All 26data-table*test files pass (189 tests).Generated by Claude Code