fix(components): a page:tabs item visibleWhen that faults withholds its tab (objectui#13286) by objectstack-fleet[bot] · Pull Request #13297 · objectstack-ai/objectui

objectstack-fleet · 2026-10-21T03:53:13Z

Fixes #13286
Clause-②: no

What changed

A page:tabs item visibleWhen that faults on evaluation now fails closed: the tab (header and panel) is withheld instead of drawn. Faults covered: a source over the CEL engine's AST bound ([bounds] Exceeded maxAstNodes), a type error, an unbound root, a missing function, a malformed source, and a declared value that cannot be evaluated at all.

PageTabsRenderer.isItemVisible (packages/components/src/renderers/layout/containers.tsx) still makes ONE evaluateCondition call. It reads the fault off that call's onFault and overrides the evaluator's fail-soft true. It does not use throwOnError, which would evaluate a CEL envelope twice.
An absent visibleWhen still means visible. A blank one ('', whitespace, an empty-source envelope, i.e. hasDeclaredPredicate false) still means "no gate". It is visible and diagnosed with [blank] as before.
Logged once: the fault goes through the shared reportUnresolvableVisibilityPredicate, with the same dedupe Set keyed on (node type, key, source). It now passes the 'withholding' gate kind, the reporter's fail-closed visibility copy, so the console line says the tab was WITHHELD. It no longer says "the gate did NOT bite".
Active tab: a withheld active tab falls back to the first visible tab. This reuses the existing path a false predicate takes (the filtered items feeding activeValue), and pin (e) measures it.
content/docs/guide/metadata-diagnostics.md: the paragraph that said every node gate in this family keeps its verdict now names the page:tabs item gate as the one that fails closed. Without that edit the sentence would be false after this change.

Sites changed and sites left

Site	Verdict on a fault	Done here
`page:tabs` item `visibleWhen` (`isItemVisible`)	was visible, now hidden	changed
`page:tabs` count-probe gates (`isGateOpen`)	visible	left alone. It mirrors the body's node gate so a badge counts what the body draws. Flipping it alone would make the badge disagree with the panel.
Node-level `visibleWhen` / `visible` / `visibleOn` in `SchemaRenderer` (`packages/react`)	visible (documented fail-soft)	left alone. It is outside this claim's file surface, and its docblock records flipping it as a shipped-behaviour change on a live surface. It is raised in the report as an open question.
`page:header` action `visible` / `disabled`	already hidden / disabled	nothing to do
`page:header` action `hidden`	not hidden	left: a header-action gate, not a page-component visibility predicate
Form field rules (`resolveFieldRuleState` / `evalFieldPredicate`), form sections and field-group tabs	documented table	not changed (ruling); pin (d) is the control

Tests

New packages/components/src/__tests__/page-tabs-visible-when-fail-closed-13286.test.tsx:

(a) a throwing item predicate (bare string and CEL envelope) is not rendered; two renders with fresh schema objects log ONE warning;
(b) CONTROL: valid false hides, true shows, absent shows, blank shows, and none of them is reported as withheld;
(c) an over-budget CEL source (120 OR-ed terms) is withheld with a [bounds] reason, while the same shape at 4 terms evaluates and shows;
(d) CONTROL: a form field whose visibleWhen faults is still drawn;
(e) an active tab whose predicate starts faulting vanishes and the first visible panel shows.

Updated page-tabs-visible-when-fault-warning.test.tsx: its two cases asserted the old fail-open draw. They now assert the tab is withheld, and their report assertions are unchanged.

Runs, at head c40f99849c:

the touched/new pins plus page-tabs-visibility.test.tsx: Test Files 3 passed (3), Tests 20 passed (20);
the family naming the touched files (34 files: every page-tabs-* / pageTabs* test, plus each test that names containers.tsx, across components, react, app-shell, plugin-grid, types, scripts and console): Test Files 34 passed (34), Tests 791 passed (791), on the first commit;
pnpm --filter @object-ui/components type-check (tsc --noEmit && tsc -p tsconfig.test.json; the second program includes src/**/*.test.tsx): exit 0, after pnpm --filter '@object-ui/components^...' build exit 0.

The full packages/components directory, and the rest of pnpm test, are left to CI.

Ablation: restoring the fail-open return (return declared && faulted ? false : verdict; replaced by return verdict; through ablation-replace.mjs; the anchor count went 1 to 0) turned (a) x2, (c) and (e) RED (Tests 4 failed | 2 passed (6)). The controls (b) and (d) stayed green. The restore is proven by blob hash: HEAD blob 2067d62d9a2d was mutated to 6e32bd0b1c7b and restored to 2067d62d9a2d, and git diff HEAD is empty. No dist/ step applies: the test reaches containers.tsx through a relative source import (import '../renderers').

Gates (exit codes): check:phantom-deps 0, check:self-import 0, check:unreferenced-sources 0, check:doc-example-readers 0, check:handler-key-reads 0, check:side-effects-array 0, check:element-data-source-declaration 0, check:spec-symbols 0, check:action-forward-parity 0, check:designer-field-key-parity 0, check:icon-record-names 0, check:i18n-keys 0, check:i18n-drift 0, check:i18n-designer-parity 0, check:control-bytes 0, check:doc-types 0, check:new-line-citations 0, scripts/check-hand-rolled-comment-mask.mjs 0, scripts/check-changeset-fixed.mjs 0, scripts/check-changeset-presence.mjs 0. check:spec-floors exits 1 because it needs a whole-workspace build artifact (no-artifact), so it is NOT MEASURED here.

Lint, narrowed to the 3 changed source files with the package's own eslint . config: --format json counts 3 files and 0 errors. With --no-inline-config there is 1 error, at the existing react-hooks/static-components site whose inline disable that flag ignores; it is not on a changed line. Type-aware linting is not configured in eslint.config.js (no parserOptions.project), so this diff cannot move a verdict in any untouched file.

Acceptance notes

The 'withholding' copy names "a navigation entry". A tab strip is in-page navigation, so the sentence is true here. A surface-neutral wording would need an edit to packages/react/src/utils/visibilityDiagnostic.ts, which is outside this claim. Carrier: none.

Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB

Generated by Claude Code

…ts tab (objectui#13286) A declared item predicate that cannot be evaluated (over the CEL AST bound, a type error, an unbound root, a missing function) used to fall back to visible, drawing the tab for a viewer the predicate was written to exclude. It now fails closed, read off the single engine call's onFault, and is reported once per source through the shared reporter with the withholding consequence. Absent and blank predicates still mean visible; form field rules keep their documented fail-open. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB

… pin Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB

github-actions · 2026-10-21T03:57:41Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 77 chunks)	3224.6 KB	3744.1 KB
Main entry chunk (gzip)	81.3 KB	350 KB
Entry file	`index-unif9gR9.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (buildIdentity.js)	0.80KB	0.49KB
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.41KB	7.90KB
app-shell (runtime-config.js)	24.52KB	8.48KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	45.59KB	12.03KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	42.84KB	11.66KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	617.43KB	150.56KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	252.96KB	70.67KB
fields (index.js)	294.69KB	75.35KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	41.40KB	12.01KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	55.56KB	16.21KB
plugin-charts (index.js)	86.06KB	23.66KB
plugin-chatbot (index.js)	238.47KB	56.30KB
plugin-dashboard (index.js)	147.53KB	39.95KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	266.70KB	70.83KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	186.64KB	48.54KB
plugin-gantt (index.js)	178.46KB	45.13KB
plugin-grid (index.js)	276.74KB	76.89KB
plugin-kanban (index.js)	64.49KB	19.83KB
plugin-list (index.js)	149.81KB	39.28KB
plugin-map (index.js)	27.17KB	9.00KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.31KB	11.88KB
plugin-tree (index.js)	15.27KB	5.40KB
plugin-view (index.js)	94.54KB	24.33KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	126.45KB	41.40KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.71KB	2.11KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (product-blocks.js)	0.20KB	0.19KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

claude added 2 commits October 21, 2026 03:42

test(components): type the page-variable writer in the objectui#13286…

c40f998

… pin Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB

objectstack-fleet Bot assigned baozhoutao Oct 21, 2026

github-actions Bot added documentation Improvements or additions to documentation package: components tests labels Oct 21, 2026

objectstack-fleet Bot mentioned this pull request Oct 21, 2026

SchemaRenderer node visibleWhen still fails open on a fault; page:tabs items now fail closed #13299

Closed

objectstack-fleet Bot mentioned this pull request Oct 21, 2026

console: a page component predicate that faults on evaluation (e.g. a page:tabs item visibleWhen over the CEL bounds) fails OPEN, so a tab draws for a user its predicate excludes #13286

Closed

objectstack-fleet Bot marked this pull request as ready for review October 21, 2026 04:06

objectstack-fleet Bot enabled auto-merge October 21, 2026 04:06

objectstack-fleet Bot added this pull request to the merge queue Oct 21, 2026

Merged via the queue into main with commit 7c405b7 Oct 21, 2026
37 checks passed

objectstack-fleet Bot deleted the claude/issue-13286-page-predicate-fail-closed branch October 21, 2026 04:19

This was referenced Oct 21, 2026

[PM seat] domain:ui · seat 2 — 🟢 baozhoutao · session_01XVp19E1MYUTFM3dnkwz8gB · batch 1 (container restarts) · 70 landed · in flight #12625 #9771

Open

Visibility fault console line calls a withheld page node or tab "a navigation entry" #13303

Closed

Navigation Menu

Repository navigation

fix(components): a page:tabs item visibleWhen that faults withholds its tab (objectui#13286) - #13297

fix(components): a page:tabs item visibleWhen that faults withholds its tab (objectui#13286)#13297
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-13286-page-predicate-fail-closed

objectstack-fleet Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 21, 2026

What changed

Sites changed and sites left

Tests

Acceptance notes

Uh oh!

github-actions Bot commented Oct 21, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants