[FIX]hr_payroll_account: Incorrect user error due to line variable - #135
Merged
Merged
Conversation
odoomates
added a commit
that referenced
this pull request
Sep 18, 2026
…heck and journal xpath om_hr_payroll_account - Confirming a payslip raised "Missing Debit Or Credit Account in Salary Rule" whenever no single salary rule carried both accounts, even though the debit and the credit side may legitimately come from two different rules. The check now looks at the accounts of the whole payslip. Reported in PR #135. om_account_accountant - The journal xpath required the payment method fields to sit directly inside a <list>, so it broke as soon as another module wrapped or altered it. Reported in PR #198.
odoomates
added a commit
that referenced
this pull request
Sep 18, 2026
…heck and journal xpath om_hr_payroll_account - Confirming a payslip raised "Missing Debit Or Credit Account in Salary Rule" whenever no single salary rule carried both accounts, even though the debit and the credit side may legitimately come from two different rules. The check now looks at the accounts of the whole payslip. Reported in PR #135. om_account_accountant - The journal xpath required the payment method fields to sit directly inside a <list>, so it broke as soon as another module wrapped or altered it. Reported in PR #198.
odoomates
added a commit
that referenced
this pull request
Sep 18, 2026
…heck and journal xpath om_hr_payroll_account - Confirming a payslip raised "Missing Debit Or Credit Account in Salary Rule" whenever no single salary rule carried both accounts, even though the debit and the credit side may legitimately come from two different rules. The check now looks at the accounts of the whole payslip. Reported in PR #135. om_account_accountant - The journal xpath required the payment method fields to sit directly inside a <list>, so it broke as soon as another module wrapped or altered it. Reported in PR #198.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not initialized
It looks like this code was copied from a few lines below where the line variable was initialised through the for loop. This suggestion works but the original code may be better because the code no longer checks if all lines have valid debit and credit accounts.