Skip to content

Discuss the return type of query_statements_by_ids methods  #456

Description

@wilbrdt

Feature Request

We should discuss the return type of the query_statements_by_ids backend methods, if we should keep them as they will be in v4.0.0 (returning a sync/async generator) or if they should return a list instead.

query_statements_by_ids returning generators seems to induce a lot of code replications and greatly complicates the API, for a potentially (not measured) small improvement in performance.

Originally found by @SergioSim in #416 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions