馃敡(project) add pre-commit-config.yaml - #637
Open
piptouque wants to merge 2 commits into
Open
Conversation
piptouque
force-pushed
the
feat_add_pre-commit
branch
3 times, most recently
from
September 7, 2026 15:36
58b107d to
1558b10
Compare
added 2 commits
September 7, 2026 17:42
This config does not include `gitlint`. It should instead be installed with `gitlint install` and managed separatly. This is because we use a custom gitlint filter that needs the `requests` package, so we need access to the gitlint env (preferably pipx).
Using `pre-commit run --all`. Implemented suggestions to replace duplicate `# noqa:` statements related to 'too many arguments' in children classes by an `@override` property.
piptouque
force-pushed
the
feat_add_pre-commit
branch
from
September 7, 2026 15:45
1558b10 to
2960b02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
I've been using
pre-commitwith this project. Since nopre-commit-config.yamlhas been committed to main,I've had to keep my config in a private commit which is inconvenient.
It seems strange to me, so I'm putting it forward.
It applies
blackandruff-check, as well as some yaml checks.Note that this config does not include
gitlint.It should instead be installed with
gitlint installand managed separately.This is because we use a custom gitlint filter that needs the
requestspackage,so we need access to the gitlint env (preferably pipx).
Proposal
pre-commit-config.yamlpre-commit run --allto assert that the result passes QA