Conversation
|
I'll back port the documentation changes to 1.28.0 once reviews have finished. |
Ekhorn
changed the title
Ekhorn
changed the title
wborn
left a comment
wborn
left a comment
There was a problem hiding this comment.
This is an initial AI-assisted review.
The new Notifications documentation is comprehensive and generally matches the current notification-management implementation. One permissions statement is stale relative to the current OpenRemote authorization model and should be corrected before merge. There is also a smaller inconsistency in the description of how notification rows correspond to recipients.
ba96d2c to
e46f2de
Compare
wborn
left a comment
wborn
left a comment
There was a problem hiding this comment.
The previous blocking authorization issue has been addressed, and the updated explanation of push-notification recipients now matches the implementation.
One small recipient-description inconsistency remains for emails sent through assets, but it does not need to block the PR.
This review was AI-assisted.
AI found no further blocking issues. Manual maintainer review is still needed before merge.
e46f2de to
fe166cb
Compare
2 participants
No description provided.