Conversation
MartinaeyNL
left a comment
MartinaeyNL
left a comment
There was a problem hiding this comment.
Looks OK to me.
Let's align with the changes necessary in the openremote/openremote pull request.
Blocked by openremote/openremote#3218
…bring from the README of the project
wborn
left a comment
wborn
left a comment
There was a problem hiding this comment.
This is an additional AI-assisted review.
The observability grouping and tracing documentation look good overall. One OpenTelemetry configuration detail should be aligned with openremote/openremote#3218.
| OTEL_TRACES_EXPORTER=otlp | ||
| OTEL_EXPORTER_OTLP_ENDPOINT=http://alloy-otel:4318 | ||
| OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf | ||
| OTEL_INSTRUMENTATION_COMMON_DB_STATEMENT_SANITIZER_ENABLED=true |
There was a problem hiding this comment.
openremote/openremote#3218 pins the Java agent at 2.30.0. In that release, otel.instrumentation.common.db-statement-sanitizer.enabled is already deprecated and scheduled for removal in 3.0; the replacement is otel.instrumentation.common.db.query-sanitization.enabled (OTEL_INSTRUMENTATION_COMMON_DB_QUERY_SANITIZATION_ENABLED).
Could both PRs use the replacement instead of introducing the deprecated option?
3 participants
…tion