Restore dropped assertion messages across the test suite - #4461
Merged
Merged
Conversation
nickbianco
added this pull request to stack #4462
September 24, 2026 16:14
nickbianco
force-pushed
the
restore_assert_messages
branch
from
September 24, 2026 16:55
538ffa4 to
11d9e9d
Compare
nickbianco
force-pushed
the
restore_assert_messages
branch
2 times, most recently
from
September 24, 2026 16:59
c4f7b23 to
cb21521
Compare
nickbianco
marked this pull request as ready for review
September 24, 2026 17:13
adamkewley
approved these changes
Sep 28, 2026
adamkewley
left a comment
Contributor
There was a problem hiding this comment.
@adamkewley reviewed 16 files and all commit messages, and made 2 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nickbianco).
OpenSim/Simulation/tests/testFrames.cpp line 137 at r1 (raw file):
rod1.getMobilizedBodyIndex() == offsetFrame->getMobilizedBodyIndex() && "testPhysicalOffsetFrameOnBody(): incorrect MobilizedBodyIndex");
Is the function name necessary in the messages? Cant the assertion macro pull this out with FUNC or similar?
nickbianco
force-pushed
the
restore_assert_messages
branch
from
September 28, 2026 15:20
cb21521 to
83460d3
Compare
nickbianco
force-pushed
the
restore_assert_messages
branch
from
September 28, 2026 15:36
83460d3 to
3458807
Compare
nickbianco
force-pushed
the
restore_assert_messages
branch
2 times, most recently
from
September 28, 2026 16:01
7ea3636 to
b15c338
Compare
nickbianco
force-pushed
the
restore_assert_messages
branch
from
September 28, 2026 16:10
b15c338 to
0bfb76a
Compare
adamkewley
approved these changes
Sep 28, 2026
adamkewley
left a comment
Contributor
There was a problem hiding this comment.
@adamkewley reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nickbianco).
nickbianco
force-pushed
the
restore_assert_messages
branch
from
September 28, 2026 19:07
0bfb76a to
064edfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up based on feedback in #4458.
Brief summary of changes
ASSERTand replace usages withOPENSIM_ASSERT_ALWAYS#4458.calibrated_pelvis_rot.osimwhich gets generated bytestOpenSense.cpp, but is not a requirement to run the test. Also comments out theoutput_model_fileproperty value in the test setup file to prevent further file generation.Testing I've completed
Looking for feedback on...
Ran tests locally + CI.
CHANGELOG.md (choose one)
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is