Skip to content

[3/9] [UI]: Add OtTableServer, a table with server-driven pagination - #1058

Closed
daviddamilola wants to merge 2 commits into
mainfrom
ot-table-server
Closed

daviddamilola wants to merge 2 commits into
mainfrom
ot-table-server

Conversation

@daviddamilola

Copy link
Copy Markdown
Contributor

A react-table instance with manual pagination and sorting: every page change runs the query with index/size variables (the API's page input) and the table holds one page at a time. Columns are typed with OtTableColumn.

  • getSortVariables maps the sorting state to query variables (server sort)
  • searchVariable sends the search text to the server; without it a search term downloads the whole dataset once and filters it locally with the same matcher as OtTable, paginating the matches locally
  • export walks every page with useBatchDownloader
  • the styled table layout parts declare their custom props

[scoped_application]: Short description

PR Tittle Format: [Genetics || Platform || PackageName || AppConfig]: Short description mentioning the affected page and/or section component

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Issue: (link)
Deploy preview: (link)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation

A react-table instance with manual pagination and sorting: every page change
runs the query with index/size variables (the API's page input) and the table
holds one page at a time. Columns are typed with OtTableColumn<Row>.

- getSortVariables maps the sorting state to query variables (server sort)
- searchVariable sends the search text to the server; without it a search
  term downloads the whole dataset once and filters it locally with the same
  matcher as OtTable, paginating the matches locally
- export walks every page with useBatchDownloader
- the styled table layout parts declare their custom props
@daviddamilola
daviddamilola deleted the ot-table-server branch October 20, 2026 11:31
@daviddamilola
daviddamilola restored the ot-table-server branch October 20, 2026 11:34
@daviddamilola daviddamilola reopened this Oct 20, 2026
@daviddamilola
daviddamilola deleted the ot-table-server branch October 20, 2026 11:34
@daviddamilola
daviddamilola restored the ot-table-server branch October 20, 2026 12:35
@daviddamilola daviddamilola reopened this Oct 20, 2026
@daviddamilola daviddamilola changed the title [UI]: Add OtTableServer, a table with server-driven pagination [3/9] [UI]: Add OtTableServer, a table with server-driven pagination Oct 20, 2026
@carcruz

carcruz commented Oct 21, 2026

Copy link
Copy Markdown
Member

Superseded by the re-cut new API stack (#1059–#1083). Commits and authorship are kept there. Tracking: opentargets/issues#4596. Closing.

@carcruz carcruz closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants